fix: use POSIX regex for cross-platform compatibility #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace \s with [[:space:]] in grep/sed patterns throughout the release workflow. The \s shorthand is not supported in POSIX ERE (used by grep -E and sed -E on Ubuntu), causing version extraction and changelog parsing to fail silently. This fix ensures the whatsnew generation correctly includes past 3 versions in Google Play release notes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the Google Play whatsnew generation where only the current version's changelog was shown instead of the past 3 versions. The root cause was the use of \s regex shorthand, which is not supported in POSIX ERE (used by grep -E and sed -E on Ubuntu). All instances of \s have been replaced with the POSIX-compliant [[:space:]] character class.
- Replaced
\swith[[:space:]]in all regex patterns throughout the release workflow - Fixed version extraction from config.gradle
- Fixed changelog validation and parsing
- Fixed GitHub release notes generation
- Fixed Google Play whatsnew generation to include past 3 versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Google Play whatsnew was only showing the current version's changelog instead of the past 3 versions.
Example output (broken):
Root Cause
The
\sregex shorthand is not supported in POSIX ERE (used bygrep -Eandsed -Eon Ubuntu). This caused:Fix
Replaced all
\swith[[:space:]]throughout the release workflow:🤖 Generated with Claude Code