Skip to content

chore: remove Lumo iconset from bundles#8072

Closed
sissbruecker wants to merge 8 commits intomainfrom
chore/remove-lumo-icons-from-bundles
Closed

chore: remove Lumo iconset from bundles#8072
sissbruecker wants to merge 8 commits intomainfrom
chore/remove-lumo-icons-from-bundles

Conversation

@sissbruecker
Copy link
Copy Markdown
Contributor

@sissbruecker sissbruecker commented Sep 24, 2025

Follow-up from #8068.

Removes the Lumo SVG iconset from the default bundles, as those should not contain theme specific code. The iconset will be loaded automatically when using the LumoIcon class, however it will require building a custom bundle.

Note that icons used by Vaadin components themselves will still be loaded by default as they are included as font icons within lumo.css.

@mshabarov
Copy link
Copy Markdown
Contributor

We perhaps need a new Flow 25 alpha release to fix the validation as now platform code is running agains older Flow code that uses older Jackson.

@ZheSun88
Copy link
Copy Markdown
Contributor

ZheSun88 commented Sep 24, 2025

@mshabarov if the flow snapshot is ready, we can also update use flow snapshot version the versions.json.
but i am afraid that the build will fail with the jackson incompatibility issue.

ah.. the failure is as in #8074

@ZheSun88 ZheSun88 enabled auto-merge (squash) October 2, 2025 08:12
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ mshabarov
✅ ZheSun88
❌ sissbruecker
You have signed the CLA already but the status is still pending? Let us recheck it.

@mshabarov mshabarov removed their assignment Jan 14, 2026
@ZheSun88
Copy link
Copy Markdown
Contributor

ZheSun88 commented Feb 18, 2026

relavent ticket for further investigation. vaadin/flow#23563

@sissbruecker
Copy link
Copy Markdown
Contributor Author

Closing this for now, this should be properly looked at and fixed by vaadin/flow#23563

auto-merge was automatically disabled February 20, 2026 10:43

Pull request was closed

@github-project-automation github-project-automation Bot moved this from 🔎Iteration reviews to Done in Vaadin Flow | Hilla | Kits ongoing work Feb 20, 2026
@sissbruecker sissbruecker deleted the chore/remove-lumo-icons-from-bundles branch February 20, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants