Skip to content

add explicit callout for user.email in the oauth skill#26

Merged
tmcw merged 3 commits into
mainfrom
add-notes-to-oauth-skill
Jun 10, 2026
Merged

add explicit callout for user.email in the oauth skill#26
tmcw merged 3 commits into
mainfrom
add-notes-to-oauth-skill

Conversation

@potluck

@potluck potluck commented Jun 9, 2026

Copy link
Copy Markdown

Addresses https://github.com/val-town/val.town/issues/13695

Proposing this lightweight fix for now since email is one of the most important fields to know about. Addresses the issue of the MCP needing to fetch our oauth docs to verify that we include user.email.

@changeset-bot

changeset-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d0e42bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@valtown/skills Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@potluck potluck requested a review from jxnblk June 9, 2026 20:28
@potluck

potluck commented Jun 9, 2026

Copy link
Copy Markdown
Author

@jxnblk does an update like this require a version bump?

Comment thread plugin/skills/oauth/SKILL.md Outdated
## Reading the current user

Call `getOAuthUserData(rawRequest)` from any route. In Hono, `rawRequest` is `c.req.raw`. It returns the session data (with `user.username` and other Val Town profile fields) if the request is authenticated, or `null` otherwise.
Call `getOAuthUserData(rawRequest)` from any route. In Hono, `rawRequest` is `c.req.raw`. It returns the session data (with `user.username`, `user.email`, and other Val Town profile fields) if the request is authenticated, or `null` otherwise.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should considering showing this; i.e. make it more like the library's own README:

https://www.val.town/x/std/oauth#getoauthuserdatareq-request-promisesessiondata--null

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the full SessionData struct in 16a233f — should address this.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@potluck potluck requested a review from jxnblk June 9, 2026 21:47
@tmcw tmcw merged commit 634a08b into main Jun 10, 2026
1 check passed
@tmcw tmcw deleted the add-notes-to-oauth-skill branch June 10, 2026 15:46
@jxnblk

jxnblk commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

@jxnblk does an update like this require a version bump?

@potluck sorry for the delay, yes, bumping the version makes sure the npm package gets published and the plugin gets updated. You should be able to use changesets next time, but that's what d0e42bd is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants