Skip to content

Add cividis and oranges colorblind-friendly isochrone palettes (#191) #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AaravJalan wants to merge 3 commits into
base: master
Choose a base branch
from
+31 −7
Open

Add cividis and oranges colorblind-friendly isochrone palettes (#191) #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
666b5d8
add cividis and oranges colorblind-friendly isochrone palettes (#191)
AaravJalan Mar 23, 2026
e95797e
Merge branch 'master' into fix/191-colorblind-isochrone-palette
AaravJalan Mar 24, 2026
90ea655
Removed Oranges, Reordered Colorblind-Friendly
AaravJalan Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/utils/isochrone-palettes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import { describe, it, expect } from 'vitest';
import { getPaletteColor, DEFAULT_FILL } from './isochrone-palettes';
import {
getPaletteColor,
DEFAULT_FILL,
ISOCHRONE_PALETTES,
} from './isochrone-palettes';

const BINARY = ['#000000', '#ffffff'];

Expand Down Expand Up @@ -46,3 +50,18 @@ describe('getPaletteColor', () => {
expect(getPaletteColor(VIRIDIS, 60 / 60)).toBe('#fde725');
});
});

describe('ISOCHRONE_PALETTES', () => {
it('includes colorblind-friendly palettes', () => {
const ids = ISOCHRONE_PALETTES.map((p) => p.id);
expect(ids).toContain('viridis');
expect(ids).toContain('cividis');
});

it('labels colorblind-friendly palettes correctly', () => {
const viridis = ISOCHRONE_PALETTES.find((p) => p.id === 'viridis');
const cividis = ISOCHRONE_PALETTES.find((p) => p.id === 'cividis');
expect(viridis?.label).toContain('colorblind-friendly');
expect(cividis?.label).toContain('colorblind-friendly');
});
});
17 changes: 11 additions & 6 deletions src/utils/isochrone-palettes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export type PaletteId = 'default' | 'viridis' | 'plasma' | 'blues';
export type PaletteId = 'default' | 'viridis' | 'plasma' | 'blues' | 'cividis';

export const DEFAULT_FILL = '#6200ea';

Expand All @@ -16,11 +16,6 @@ export const ISOCHRONE_PALETTES: IsochronePalette[] = [
label: 'Default',
colors: null,
},
{
id: 'viridis',
label: 'Viridis (colorblind-friendly)',
colors: ['#440154', '#3b528b', '#21918c', '#5ec962', '#fde725'],
},
{
id: 'plasma',
label: 'Plasma',
Expand All @@ -31,6 +26,16 @@ export const ISOCHRONE_PALETTES: IsochronePalette[] = [
label: 'Blues',
colors: ['#084594', '#2171b5', '#4292c6', '#9ecae1', '#deebf7'],
},
{
id: 'viridis',
label: 'Viridis (colorblind-friendly)',
colors: ['#440154', '#3b528b', '#21918c', '#5ec962', '#fde725'],
},
{
id: 'cividis',
label: 'Cividis (colorblind-friendly)',
colors: ['#00204d', '#31446b', '#666870', '#958f78', '#e4cf5b'],
},
];

export function isPaletteId(value: string): value is PaletteId {
Expand Down
Loading