TD-312: Allow to run steps conditionally @ parallel workflow#24
Open
TD-312: Allow to run steps conditionally @ parallel workflow#24
Conversation
kehitt
reviewed
Jun 22, 2022
Comment on lines
+139
to
+140
| echo "::set-output name=exists::false" | ||
| echo "::notice file=rebar.config::Plugin 'erlfmt' is missing, can not check formatting." |
Contributor
There was a problem hiding this comment.
Я предлагаю как минимум повысить до warning или даже error, notice-сообщения какие-то ужасно незаметные получаются.
Как максимум мне вообще не особо нравится, что получить зеленую галочку на pr можно, поменяв какой-то файл, отличный от тех, что под .github (то, чего я хотел избежать, когда выкидывал использование makefile из конфигураций CI). Может добавить какой нибудь параметр сюда, вроде allow-optional-linting/allow-optional-formatting c дефолтом false?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #22.