Skip to content

Update valitydev/java-workflow action to v4 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update valitydev/java-workflow action to v4 #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@

jobs:
build:
uses: valitydev/java-workflow/.github/workflows/maven-service-build.yml@v3
uses: valitydev/java-workflow/.github/workflows/maven-service-build.yml@v4

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 18 days ago

To fix the problem, you should explicitly restrict the GITHUB_TOKEN permissions in this workflow, instead of relying on repository or organization defaults. The minimal safe starting point is usually to set contents: read (and other permissions only if needed) at either the root of the workflow or within the specific job.

The best fix here, without changing existing functionality, is to add a permissions block under the build job so that only this job is affected and so that we avoid making assumptions about other jobs that might exist in this file (we have only seen this one). Since this workflow only calls a reusable Maven build workflow and there is no indication it needs write access, we set contents: read as a conservative, least-privilege default. If the reusable workflow requires additional permissions, they can be added later, but starting with read-only is aligned with the CodeQL recommendation.

Concretely, in .github/workflows/build.yml, under jobs: build:, add:

    permissions:
      contents: read

right before the uses: line. No imports or additional methods are needed, as this is a YAML configuration change only.

Suggested changeset 1
.github/workflows/build.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -7,4 +7,6 @@
 
 jobs:
   build:
+    permissions:
+      contents: read
     uses: valitydev/java-workflow/.github/workflows/maven-service-build.yml@v4
EOF
@@ -7,4 +7,6 @@

jobs:
build:
permissions:
contents: read
uses: valitydev/java-workflow/.github/workflows/maven-service-build.yml@v4
Copilot is powered by AI and may make mistakes. Always verify output.
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

jobs:
deploy:
uses: valitydev/java-workflow/.github/workflows/maven-service-deploy.yml@v3
uses: valitydev/java-workflow/.github/workflows/maven-service-deploy.yml@v4
secrets:
github-token: ${{ secrets.GITHUB_TOKEN }}
mm-webhook-url: ${{ secrets.MATTERMOST_WEBHOOK_URL }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
Loading