Add valkey-GLIDE PHP client to recommended clients list#557
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR adds the Valkey PHP GLIDE client to the recommended clients configuration by extending the ChangesPHP Valkey GLIDE Client Addition
Comment |
|
@adrianluna Thanks for the contribution! I'm excited about GLIDE PHP but would you mind fixing your DCO issue? I've also swapped this over to draft since it's dependent on another PR so it doesn't get accidentally merged.. Once that is merged, swap it back and make it ready for review. |
Signed-off-by: Adrian Luna <adrian.luna.rojas@gmail.com>
9e87a88 to
016eb86
Compare
|
@stockholmux Thanks for moving the PR to draft and the link for the DCO issue, I'll put it back in review once the other PR is merged. |
|
| Filename | Overview |
|---|---|
| content/clients/_index.md | Adds /php/valkey-GLIDE.json to recommended_clients_paths; entry is correctly placed alongside other PHP clients and follows the naming convention of existing GLIDE entries for other languages. |
Sequence Diagram
sequenceDiagram
participant Site as valkey-io.github.io (this PR)
participant Doc as valkey-doc (PR #443)
participant Builder as Site Builder
Doc->>Doc: Add clients/php/valkey-GLIDE.json
Site->>Site: Add /php/valkey-GLIDE.json to recommended_clients_paths
Builder->>Site: Read _index.md → discover recommended_clients_paths
Builder->>Doc: Fetch /php/valkey-GLIDE.json
Doc-->>Builder: Return PHP GLIDE client metadata
Builder->>Builder: Render PHP client table entry
Reviews (1): Last reviewed commit: "Add valkey-GLIDE PHP client to recommend..." | Re-trigger Greptile
| "/go/valkey-go.json", | ||
| "/php/phpredis.json", | ||
| "/php/predis.json", | ||
| "/php/valkey-GLIDE.json", |
There was a problem hiding this comment.
Dependency on companion PR must be merged first
This entry references /php/valkey-GLIDE.json, which is added in the companion PR valkey-io/valkey-doc#443. If this website PR is merged and deployed before the metadata file lands in the valkey-doc repo (and that repo's data is synced/published), the site builder may silently skip or error on the missing JSON file. Please ensure the data PR is merged and the doc data is available before this change goes live.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Description
Adds the Valkey GLIDE PHP client to the recommended clients list on the clients page.
This is the companion change to valkey-io/valkey-doc#443, which adds the
clients/php/valkey-GLIDE.jsonmetadata file. This PR ensures the website renders the new entry by including it inrecommended_clients_paths.Changes
/php/valkey-GLIDE.jsontorecommended_clients_pathsincontent/clients/_index.mdTesting