build: add darwin compatible dynamic libraries#1
Open
thomasgillis wants to merge 1 commit intovanreeslab:mainfrom
Open
build: add darwin compatible dynamic libraries#1thomasgillis wants to merge 1 commit intovanreeslab:mainfrom
thomasgillis wants to merge 1 commit intovanreeslab:mainfrom
Conversation
add dylib extensions to the dynamic libs for usage on darwin systems and compatibility with -rpath linker option
|
looks good! did you try it on non-mac systems? i'm not familiar enough to see if the code is valid when the new |
Collaborator
Author
|
Good catch, not yet. Will do before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solve the dynamic lib building on darwin systems.
Add dylib extensions to the dynamic libs for usage on darwin systems and compatibility with -rpath linker option
note: this should be solved by
autotoolseventually for a long term solution but at least we support darwin systems now