Add private dependencies to squashfuse.pc #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasi
reviewed
Aug 18, 2025
configure.ac
Outdated
| [AC_DEFINE(SQFS_BROKEN_DIR_OFFSETS, 1, [Handle broken directory offsets])]) | ||
|
|
||
| AC_SUBST([sq_decompressors]) | ||
| AC_SUBST([sq_decompressors_pc]) |
Owner
There was a problem hiding this comment.
Rename to sq_decompressors_pkgconf or something? pc is a bit non-obvious if you don't know the context
Owner
|
Looks good, one note. |
amazingakai
force-pushed
the
work/amazingakai/add-private-requires
branch
from
54418f5 to
6d21f76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that
pkg-config --static squashfuseincludes all private dependencies, which is required for static linking.