Skip to content

Run the Sign function in an STA thread to be able to sign js files#258

Open
air2 wants to merge 2 commits intovcsjones:mainfrom
air2:main
Open

Run the Sign function in an STA thread to be able to sign js files#258
air2 wants to merge 2 commits intovcsjones:mainfrom
air2:main

Conversation

@air2
Copy link

@air2 air2 commented Jun 18, 2024

Implements the fix proposed by @engycz in #169

@vcsjones
Copy link
Owner

Interesting. Thanks for the fix. I am going to play around with this locally first to make sure I understand.

@ncook-hxgn
Copy link

bump?

@eponerine
Copy link

Bumping for update. Hopefully this can make it into the next release.

@vcsjones
Copy link
Owner

I haven't forgotten about this pull request. I do have some concerns about spawning potentially 1000s of threads. I realize that with the Join there will never be more then MDOP number of executing threads, but constantly creating and destroying threads makes memory usage a tad high.

Right now I am experimenting with a custom TaskScheduler for Parallel.ForEach instead. If I put together a branch with a task scheduler would folks be willing to pull it down, build AzureSignTool, and give it a try?

@eponerine
Copy link

Sure thing! We're already running @air2 branch "in production" and its working. We are willing to try an official release so we don't have to maintain our own copy of code internally.

@DarkestFM
Copy link

Anyone going to finish this pull?

@benplay2
Copy link

benplay2 commented Feb 3, 2026

Will this get implemented sometime soon or is an alternative on the way? I'm in need of signing vbs files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants