Add tests#61
Draft
MakisChristou wants to merge 1 commit into
Draft
Conversation
MakisChristou
had a problem deploying
to
default-private
GitHub Actions
Failure
| PRIVATE_KEYS= | ||
| MNEMONIC="denial kitchen pet squirrel other broom bar gas better priority spoil cross" | ||
| NETWORK_TYPE=default-private | ||
| NETWORK_TYPE=solo |
Contributor
There was a problem hiding this comment.
I suppose we dont need to push this one, as it is just local config
| } | ||
| } | ||
|
|
||
| buildCallTransaction = async (clauses, options) => { |
Contributor
There was a problem hiding this comment.
do we need to have specific method for that or we can enhance buildTransaction one ?
| expect(success).toBeTrue() | ||
| expect(httpCode).toBe(200) | ||
| expect(body?.txID).toBeDefined() | ||
| expect(body?.vmError).not.toBe("") |
Contributor
There was a problem hiding this comment.
wonder if we can add specific error we look for ? as this just checks it is not empty
| ) | ||
| }) | ||
|
|
||
| it.e2eTest('should simulate vet transfer', 'all', async function () { |
Contributor
There was a problem hiding this comment.
maybe we can add: mixed clauses (like contract call + vet transfer), tx delegation and not enough gas cases. As this should follow the same validation rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is for covering the new functionality added in Thor