chore(deps): bump ordered-float from 4.6.0 to 5.3.0#1842
chore(deps): bump ordered-float from 4.6.0 to 5.3.0#1842dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
domain: deps
dependabot
Bot
added
domain: deps
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a6c96c096
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [[package]] | ||
| name = "ordered-float" | ||
| version = "4.6.0" | ||
| version = "5.3.0" |
There was a problem hiding this comment.
Cargo.toml still constrains ordered-float to version = "4", which excludes this newly locked 5.3.0 release, so the lockfile is no longer in sync with the manifest. I checked .github/workflows/test.yml, and the check-lockfile job runs cargo update --workspace --locked; cargo update --help describes --locked as asserting that Cargo.lock remains unchanged, so this dependency resolution would need to rewrite the lockfile and block that CI job until the manifest range is bumped to allow 5.x or the lock entry is kept on 4.x.
Useful? React with 👍 / 👎.
| [[package]] | ||
| name = "ordered-float" | ||
| version = "4.6.0" | ||
| version = "5.3.0" |
There was a problem hiding this comment.
After the manifest is widened enough for this lockfile to resolve, non-test builds that include the arithmetic code still won't compile: ordered-float 5 changes NotNan<T> op T results to raw floats, but src/compiler/value/arithmetic.rs still calls .into() on results such as lhv.mul(rhs) and left.rem(right), while Value only implements From<f64> under #[cfg(any(test, feature = "test"))] in src/value/value/convert.rs:339. In default/production builds those paths therefore have no From<f64> for Value; convert the raw result explicitly or keep the 4.x API.
Useful? React with 👍 / 👎.
Bumps [ordered-float](https://github.com/reem/rust-ordered-float) from 4.6.0 to 5.3.0. - [Release notes](https://github.com/reem/rust-ordered-float/releases) - [Commits](reem/rust-ordered-float@v4.6.0...v5.3.0) --- updated-dependencies: - dependency-name: ordered-float dependency-version: 5.3.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/cargo/ordered-float-5.3.0
branch
from
6a6c96c to
99be08d
Compare
Bumps ordered-float from 4.6.0 to 5.3.0.
Release notes
Sourced from ordered-float's releases.
Commits
6cca9b8v5.3.0a980aa3Rkyv v0.8 compatibility (#182)09998b4Fix broken link in docs35507c2Version 5.2.0f6b9d9bGeneralise lifetimes for binop implementations (#181)25da208Remove old CI configuration2bb1184Install clippy and rustfmtfea67dcVersion 5.1.01841f05Merge pull request #176 from DouisLavid/master1ae6383add a missing feature check for use statement