fix: derive HINDSIGHT_API_HEALTH_URL default from HINDSIGHT_API_PORT#1709
Merged
Conversation
Contributor
|
@sg-shag thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HINDSIGHT_API_HEALTH_URLdefault is hardcoded to port 8888 and does notrespect
HINDSIGHT_API_PORT. When a custom port is set, the health checkpolls the wrong port and the container fails to start after 300s.
Fix
One-line change in
docker/standalone/start-all.sh:No behavior change when
HINDSIGHT_API_PORTis not set — defaults to 8888 as before.Closes #1708