Skip to content

fix: derive HINDSIGHT_API_HEALTH_URL default from HINDSIGHT_API_PORT#1709

Merged
benfrank241 merged 2 commits into
vectorize-io:mainfrom
sg-shag:fix/health-url-port
May 22, 2026
Merged

fix: derive HINDSIGHT_API_HEALTH_URL default from HINDSIGHT_API_PORT#1709
benfrank241 merged 2 commits into
vectorize-io:mainfrom
sg-shag:fix/health-url-port

Conversation

@sg-shag
Copy link
Copy Markdown
Contributor

@sg-shag sg-shag commented May 22, 2026

Problem

HINDSIGHT_API_HEALTH_URL default is hardcoded to port 8888 and does not
respect HINDSIGHT_API_PORT. When a custom port is set, the health check
polls the wrong port and the container fails to start after 300s.

Fix

One-line change in docker/standalone/start-all.sh:

-    API_HEALTH_URL="${HINDSIGHT_API_HEALTH_URL:-http://localhost:8888/health}"
+    API_HEALTH_URL="${HINDSIGHT_API_HEALTH_URL:-http://localhost:${HINDSIGHT_API_PORT:-8888}/health}"

No behavior change when HINDSIGHT_API_PORT is not set — defaults to 8888 as before.

Closes #1708

@benfrank241
Copy link
Copy Markdown
Contributor

@sg-shag thanks for the contribution!

@benfrank241 benfrank241 merged commit 21c71f7 into vectorize-io:main May 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HINDSIGHT_API_HEALTH_URL default ignores HINDSIGHT_API_PORT — health check always hits port 8888

2 participants