Skip to content

[1.20] move worldgen and damage types to datagen#1242

Merged
vectorwing merged 1 commit intovectorwing:dev/1.3from
Abbie5:1.20-more-datagen
Feb 28, 2026
Merged

[1.20] move worldgen and damage types to datagen#1242
vectorwing merged 1 commit intovectorwing:dev/1.3from
Abbie5:1.20-more-datagen

Conversation

@Abbie5
Copy link

@Abbie5 Abbie5 commented Feb 25, 2026

same as #1129 but for 1.20

@vectorwing
Copy link
Owner

Thanks for the PR!

I'll have to sit down and understand the changes first, as I think I've only used this form of datagen on Enchantments, during the 1.21.1 port. I'll get back with my review later.

@vectorwing vectorwing changed the base branch from 1.20 to dev/1.3 February 27, 2026 01:46
@vectorwing
Copy link
Owner

vectorwing commented Feb 27, 2026

I pointed the PR to dev/1.3 and there were no conflicts or differences. 👍

@vectorwing
Copy link
Owner

After studying the code a bit more, and comparing to the other datagen PR for similarities (#959), I think I get what's going on now, and I should be able to maintain it.

I had a few questions looking over, but I think I answered them to myself in the end. Aside from code organization (which I'll do on my own after this), this PR is good for a merge.

Since the 1.21-bound PR seems to be exactly the same, I might close that one later and simply port the 1.20 changes over when it's time, depending on how my refactoring goes.

Thank you for the contribution! ^^

@vectorwing vectorwing merged commit 2fea83f into vectorwing:dev/1.3 Feb 28, 2026
@Abbie5 Abbie5 deleted the 1.20-more-datagen branch February 28, 2026 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants