Remove optimistic task on error instead of refreshing all tasks#207
Open
S7331331337S wants to merge 2 commits intovercel-labs:mainfrom
Open
Remove optimistic task on error instead of refreshing all tasks#207S7331331337S wants to merge 2 commits intovercel-labs:mainfrom
S7331331337S wants to merge 2 commits intovercel-labs:mainfrom
Conversation
Previously when task creation failed, the code would refresh all tasks from the server to remove the optimistic task. This was inefficient. Now we remove only the specific optimistic task that failed by adding a removeTaskOptimistically function to the TasksContext. Changes: - Add removeTaskOptimistically function to app-layout.tsx - Update TasksContextType interface to include the new function - Use removeTaskOptimistically in home-page-content.tsx error handlers - Remove TODO comments that are now resolved
Contributor
|
@claude is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
…vkTe9idAKYtENqTQgfB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when task creation failed, the code would refresh all tasks from the server to remove the optimistic task. This was inefficient. Now we remove only the specific optimistic task that failed by adding a removeTaskOptimistically function to the TasksContext.
Changes: