feat(clerk): backend + frontend API compatibility with @clerk/backend and clerk-js#171
Open
pjsny wants to merge 8 commits into
Open
feat(clerk): backend + frontend API compatibility with @clerk/backend and clerk-js#171pjsny wants to merge 8 commits into
pjsny wants to merge 8 commits into
Conversation
Contributor
|
@pjsny is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| if (tokenFormat === "jwt") { | ||
| const { privateKey } = await keyPairPromise; | ||
| const jwtClaims: Record<string, unknown> = { | ||
| scopes: subject, |
Contributor
There was a problem hiding this comment.
Suggested change
| scopes: subject, | |
| scopes: [subject], |
JWT M2M token sets the scopes claim to the bare subject string instead of an array, inconsistent with the stored record's scopes: [subject]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified against
@clerk/react6.7.xAdds FAPI, M2M tokens, org domains, and webhooks