fix(dom): skip wide glyph continuation cells#74
Closed
EfeDurmaz16 wants to merge 1 commit into
Closed
Conversation
|
@EfeDurmaz16 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Gatos90
pushed a commit
to Gatos90/wterm
that referenced
this pull request
Jul 2, 2026
- Implement the get_scrollback_line WASM export against libghostty's page list (offset 0 = newest scrollback row, matching the built-in Zig core convention). Returns the used line width (trailing never-written cells trimmed). - Fix getScrollbackCell packing RGB colors unconditionally; explicit colors are now gated on colorFlags like getCell (fixes scrollback rendering black-on-black, see vercel-labs#66). - Expose CellData.width (0 = wide-glyph spacer, 1 = normal, 2 = wide) from both viewport and scrollback reads so consumers can handle CJK/emoji correctly (see vercel-labs#71/vercel-labs#74). - Add optional TerminalCore.getScrollbackLine bulk read; GhosttyCore memoizes the last line per write-generation so the renderer's per-cell loop costs one WASM crossing per line instead of one per cell. - Add scripts/build-wasm-manual.sh: builds ghostty-vt.wasm without `zig build` (explicit -target on every native step) for hosts where Zig 0.15.x cannot auto-detect the OS (e.g. macOS 26 / Darwin 25).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #71.
Verification