Drop unused InstallResult.archive_path to plug success-path leak#33
Open
versecafe wants to merge 1 commit into
Open
Drop unused InstallResult.archive_path to plug success-path leak#33versecafe wants to merge 1 commit into
versecafe wants to merge 1 commit into
Conversation
|
@versecafe is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
versecafe
force-pushed
the
fix-cef-install-result-archive-path-leak
branch
from
371c51b to
fac1e58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
installPrepared/installOfficialallocatedarchive_pathviastd.fs.path.join(allocator, ...)and returned it onInstallResult. The only caller (run) never read or freed it, so every successful install leaked the slice.Fixes #32