Skip to content

fix: api key references are present at app/session in session.ts #8181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: canary
Choose a base branch
from
+5 −4
Open

fix: api key references are present at app/session in session.ts #8181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions app/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,12 @@ export default class Session extends EventEmitter {
.join(':');
}

// Electron has a default value for process.env.GOOGLE_API_KEY
// We don't want to leak this to the shell
// Electron injects certain API keys into process.env that we don't want to leak to the shell
// See https://github.com/vercel/hyper/issues/696
if (baseEnv.GOOGLE_API_KEY && process.env.GOOGLE_API_KEY === baseEnv.GOOGLE_API_KEY) {
delete baseEnv.GOOGLE_API_KEY;
for (const key of ['GOOGLE_API_KEY', 'GOOGLE_DEFAULT_CLIENT_ID', 'GOOGLE_DEFAULT_CLIENT_SECRET']) {
if (baseEnv[key] && process.env[key] === baseEnv[key]) {
delete baseEnv[key];
}
}

const options: IWindowsPtyForkOptions = {
Expand Down