fix(examples): align with-docker-compose Dockerfiles with with-docker example #86847
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
…iles Without NODE_ENV=production, React DevTools may appear in production builds. This aligns with-docker-compose with the with-docker example.
Some native Node.js modules require libc6-compat on Alpine Linux. This aligns with-docker-compose with the with-docker example. See: https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine
…iles Replace legacy `ENV VAR value` with `ENV VAR=value` for consistency with Dockerfile best practices and the with-docker example.
comxd
force-pushed
the
fix/docker-compose-example-alignment
branch
from
3eef416 to
be8718b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aligns the
with-docker-composeexample Dockerfiles with thewith-dockerexample to ensure consistency and fix a production issue:NODE_ENV=productiontoprod.Dockerfileandprod-without-multistage.Dockerfile- Without this, React DevTools may appear in production buildslibc6-compatto all three Dockerfiles - Required for some native Node.js modules on Alpine LinuxENV VAR=valueinstead ofENV VAR value) for consistencyWhy?
When building with
prod.Dockerfile, the resulting image was missingNODE_ENV=productionin the runner stage, causing React to run in development mode (React DevTools visible in browser).The
with-dockerexample already has these configurations correctly set. This PR bringswith-docker-composeto parity.Related
Reference implementation:
examples/with-docker/Dockerfile