Overwrite annotations for self and __init__#39
Merged
Conversation
msullivan
approved these changes
Jan 15, 2026
msullivan
left a comment
msullivan
left a comment
Collaborator
There was a problem hiding this comment.
This seems fine for now but longer term we might need to do something else, like allow a specifically omitted annotation.
Comment on lines
+434
to
+448
| params, ret = typing.get_args(typ) | ||
| params = [ | ||
| ( | ||
| p | ||
| if typing.get_args(p)[0] != typing.Literal["self"] | ||
| else Param[ | ||
| typing.Literal["self"], | ||
| typing.Self, | ||
| typing.get_args(p)[2], | ||
| ] | ||
| ) | ||
| for p in params | ||
| ] | ||
| ret = type(None) if name == "__init__" else ret | ||
| typ = typing.Callable[params, ret] |
Collaborator
There was a problem hiding this comment.
Document what we are doing here
Collaborator
|
Yeah I dunno, I am pretty unsure about this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__init__should always beNoneselfcan vary by type, but ends up being very verbose, and also annoying to deal with when generating new protocols. There is alwaysGetDefineras well.