Skip to content

Added test case to verify TLS 1.3 auto-negotiation support #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sharmagot merged 9 commits into from
Nov 30, 2025
Merged

Added test case to verify TLS 1.3 auto-negotiation support #575

sharmagot merged 9 commits into from
Nov 30, 2025

Conversation

@sharmagot
Copy link
Collaborator

@sharmagot sharmagot commented Nov 13, 2025 •
edited
Loading

This MR adds a new integration test to verify that the Vertica Python client correctly supports TLS 1.3 negotiation.

The test validates that the client can successfully connect using TLS 1.3 when supported by the server.

If the server only supports TLS 1.2, the connection should gracefully fall back to it.

The test also logs the negotiated TLS version for debugging and verification purposes.

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sharmagot sharmagot force-pushed the VE-5031245-support-tls1.3-vertica-python-driver-v2 branch 2 times, most recently from 27a6e6f to 4938fc8 Compare November 26, 2025 15:17
sivaalamp
sivaalamp reviewed Nov 27, 2025
View reviewed changes
sivaalamp
sivaalamp reviewed Nov 27, 2025
View reviewed changes
sivaalamp
sivaalamp reviewed Nov 27, 2025
View reviewed changes
sivaalamp
sivaalamp reviewed Nov 27, 2025
View reviewed changes
sivaalamp
sivaalamp requested changes Nov 27, 2025
View reviewed changes
Copy link
Collaborator

@sivaalamp sivaalamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments

@sharmagot sharmagot force-pushed the VE-5031245-support-tls1.3-vertica-python-driver-v2 branch from a0134c4 to 1f6106d Compare November 30, 2025 09:46
@sivaalamp
Copy link
Collaborator

sivaalamp commented Nov 30, 2025

The test case updates look good.
Since the TOTP-related changes have already been merged through a separate PR, they can be removed from this one.
Please also update the PR description to reflect these modifications accordingly.

@sharmagot
Copy link
Collaborator Author

sharmagot commented Nov 30, 2025

The test case updates look good. Since the TOTP-related changes have already been merged through a separate PR, they can be removed from this one. Please also update the PR description to reflect these modifications accordingly.

Thanks, Siva. I’ve addressed this.
I’ve removed the TOTP-related changes from this MR and updated the PR description accordingly

sivaalamp
sivaalamp approved these changes Nov 30, 2025
View reviewed changes
Copy link
Collaborator

@sivaalamp sivaalamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes now look good to me

@sharmagot sharmagot merged commit 494fe29 into master Nov 30, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sivaalamp sivaalamp sivaalamp approved these changes

@ssharieff21 ssharieff21 Awaiting requested review from ssharieff21

@vipulkotfi vipulkotfi Awaiting requested review from vipulkotfi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sharmagot @CLAassistant @sivaalamp