-
Notifications
You must be signed in to change notification settings - Fork 7
Two frontends, both alike in dignity, in fair VHS where we lay our scene. #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
outfuckingstanding PR title |
| - ${PWD}/packages/frontend-web/web:/var/www/html | ||
|
|
||
| db-mariadb: | ||
| image: mariadb:11.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coryalder trying to understand all the differences in your branch. Are you moving to a single docker file instead of the docker-compose.sh switch?
And image: mariadb:11.4 , does this switch the DB from mysql to mariadb? is that an easy migration?
I was able to get the master branch working, but not this one so far haha
also i'm terrible at responding on github 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I ended up nuking the customized docker compose script in favour of a single docker compose file. I got rid of a bunch of the extra services that were being run, so it didn't seem super useful to keep the script around. I'm VERY open to other opinions here tho, so if you think it's worth keeping we could roll that stuff back.
As I said in slack DMs, the mariadb switch was because I encountered a problem upgrading mysql - something about database adapters, that is lost to the sands of time.
In an effort to land the feat/writing-a-lot-of-code-for-v2.0-and-all-I-got-was-this-lousy-branch-name branch, with it's majestic react frontend lovelyness.
My plan was (and still is) to deploy both frontends -
https://membership.vanhack.ca/the new react versionhttps://membership.vanhack.ca/v1/the old angular versiontodo: