[POC] SBrick Light - basic port support #194
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds basic support for the SBrick Light device, which is a 24-channel LED controller variant of the SBrick device family. The implementation includes device detection, UI channel selectors, and protocol support for controlling the device's two light banks.
Key Changes:
- Added SBrick Light device type and detection logic to distinguish it from standard SBrick devices
- Implemented SBrick Light device class with 24 channels (16 in bank 0, 8 in bank 1)
- Created UI components for channel selection with labeled ports A-H
Reviewed changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Added SBrick Light to the list of supported receivers |
| BrickController2/BrickController2/DeviceManagement/DeviceType.cs | Added SBrickLight enum value to DeviceType |
| BrickController2/BrickController2/DeviceManagement/Vengit/*.cs | Created new Vengit namespace with SBrick and SBrick Light device implementations, protocol definitions, and device manager |
| BrickController2/BrickController2/DeviceManagement/SBrickDevice.cs | Moved SBrickDevice to Vengit namespace |
| BrickController2/BrickController2/DeviceManagement/SBrickDeviceManager.cs | Removed old manager (replaced by Vengit/SBrickDeviceManager.cs) |
| BrickController2/BrickController2/DeviceManagement/DI/DeviceManagementModule.cs | Updated DI registration to use new Vengit vendor structure |
| BrickController2/BrickController2/UI/Converters/*.cs | Added SBrick Light image resource mappings |
| BrickController2/BrickController2/UI/Controls/DeviceChannelSelector.xaml* | Added UI grid layout for 24 SBrick Light channels organized in 8 ports (A-H) with 3 channels each |
| BrickController2/BrickController2/UI/Controls/DeviceChannelLabel.cs | Added channel label formatting for SBrick Light (e.g., "C.3") |
| BrickController2/BrickController2/UI/Controls/ChannelSelectorRadioButton.xaml.cs | Changed BindableProperty declarations to readonly |
| BrickController2/BrickController2/BrickController2.csproj | Added SBrick Light image resources |
| BrickController2/BrickController2.Tests/DeviceManagement/Vengit/SBrickDeviceManagerTests.cs | Added comprehensive tests for SBrick and SBrick Light device detection |
| BrickController2/BrickController2.Tests/DeviceManagement/SBrickDeviceManagerTests.cs | Removed old test file (replaced by Vengit/SBrickDeviceManagerTests.cs) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BrickController2/BrickController2/UI/Controls/DeviceChannelSelector.xaml
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/DeviceManagement/Vengit/Vengit.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2.Tests/DeviceManagement/Vengit/SBrickDeviceManagerTests.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/DeviceManagement/Vengit/SBrickDeviceManager.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/DeviceManagement/Vengit/SBrickLightDevice.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2.Tests/DeviceManagement/Vengit/SBrickDeviceManagerTests.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2.Tests/DeviceManagement/Vengit/SBrickDeviceManagerTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 18 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (success) | ||
| { | ||
| // confirm successful sending | ||
| valueBank.Commmit(); |
There was a problem hiding this comment.
Corrected spelling of 'Commmit' to 'Commit'.
Suggested change
| valueBank.Commmit(); | |
| valueBank.Commit(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.