-
Notifications
You must be signed in to change notification settings - Fork 3
Add SBrick Light - base RGB and 8*3 channels support [legacy] #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/legacy
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 27 out of 29 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BrickController2/BrickController2/Settings/RgbColorJsonConverter.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/DeviceManagement/Vengit/SBrickLightDevice.cs
Show resolved
Hide resolved
BrickController2/BrickController2/DeviceManagement/Vengit/SBrickLightDevice.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/UI/ViewModels/ControllerActionPageViewModel.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/UI/ViewModels/ControllerActionPageViewModel.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/Settings/NamedSettingExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 30 out of 33 changed files in this pull request and generated 5 comments.
Files not reviewed (1)
- BrickController2/BrickController2/Resources/TranslationResources.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BrickController2/BrickController2/Settings/RgbColorJsonConverter.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/UI/ViewModels/ControllerActionPageViewModel.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/DeviceManagement/Vengit/SBrickLightDevice.cs
Show resolved
Hide resolved
BrickController2/BrickController2/UI/Controls/DeviceChannelSelector.xaml.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/UI/ViewModels/ControllerActionPageViewModel.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 30 out of 33 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- BrickController2/BrickController2/Resources/TranslationResources.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BrickController2/BrickController2/UI/Controls/DeviceChannelSelector.xaml.cs
Outdated
Show resolved
Hide resolved
BrickController2/BrickController2/UI/Controls/DeviceChannelLabel.cs
Outdated
Show resolved
Hide resolved
|
Awaiting for the feedback from testing. |
The SBrick Light has 8 physical ports. Each port can control an RGB LED (requiring 3 channels: Red, Green, Blue) or be split into 3 separate white LEDs. This results in a total of 24 controllable channels (8 ports × 3 sub-channels).
Added support for SBrick Light device:
A-H)Device Settings

Controller Action:

Test Page:
