docs(site): update stale popup docs - #1818
Merged
Merged
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sampotts
enabled auto-merge (squash)
July 10, 2026 06:04
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (10)
Players (5)
Skins (30)
UI Components (39)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (9)
Skins (27)
UI Components (33)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (68)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (11)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretJS sizes are initial static graph totals (minified + brotli). Lazy dynamic chunks are shown separately when present.
Run |
decepulis
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1544
Summary
Update the hand-authored reference docs for popup positioning and player context so they match the current API surface.
Changes
usePlayerContextdescription and example so it no longer omits newer context fields.Testing
pnpm --dir site buildgit diff --checkNote
Low Risk
Documentation-only edits with no runtime or API behavior changes.
Overview
Brings hand-authored reference pages in line with the current popup positioning and React player context APIs.
Popover and Tooltip styling examples now include
--media-popover-boundary-offsetand--media-tooltip-boundary-offsetalongside the existing side/align offset variables.The
usePlayerContextpage drops outdated wording aboutsetMedia, reframes the hook for lower-level integrations, and updates the sample to surfacecontainerandpopupGroupinstead ofsetMedia.Reviewed by Cursor Bugbot for commit c32cb46. Bugbot is set up for automated code reviews on this repo. Configure here.