docs(site): update localized label docs - #1820
Merged
Merged
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sampotts
enabled auto-merge (squash)
July 10, 2026 06:10
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (10)
Players (5)
Skins (30)
UI Components (39)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (9)
Skins (27)
UI Components (33)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (68)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (11)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretJS sizes are initial static graph totals (minified + brotli). Lazy dynamic chunks are shown separately when present.
Run |
decepulis
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1703
Summary
Update stale accessibility wording for localized control labels so the reference docs match the i18n-aware API surface.
Changes
PlayButtonlabels can be translation keys, custom strings, or functions returning either.TimeSliderandVolumeSliderdefault aria-label text to describe locale resolution instead of hardcoded defaults.Testing
pnpm --dir site buildgit diff --checkNote
Low Risk
Documentation-only edits with no runtime or API changes.
Overview
Updates Accessibility sections in three reference pages so they match the i18n-aware
labeland defaultaria-labelbehavior.PlayButton docs now state that
labelcan be a translation key, a custom string, or a function returning either—not only a string or function.TimeSlider and VolumeSlider docs no longer describe fixed English defaults ("Seek", "Volume"); they explain that the automatic
aria-labelcomes from the active locale, withlabelstill available to override.Reviewed by Cursor Bugbot for commit d243b83. Bugbot is set up for automated code reviews on this repo. Configure here.