chore(root): refresh agent skills and docs - #1835
Merged
Merged
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (10)
Players (5)
Skins (30)
UI Components (39)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (9)
Skins (27)
UI Components (33)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (68)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (11)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretJS sizes are initial static graph totals (minified + brotli). Lazy dynamic chunks are shown separately when present.
Run |
mihar-22
changed the title
mihar-22
marked this pull request as ready for review
July 17, 2026 21:45
decepulis
reviewed
Jul 17, 2026
Collaborator
There was a problem hiding this comment.
Generally super in line with the philosophy behind this cleanup! I expect I could approve this PR.
But for now, I've only reviewed skills in my wheelhouse (since I'm coming up on the end of my day).
.agents/plans/.agents/skills/commit-prcreate-issueinvestigate-issuemaintain-agent-docsreview-branchreview-docswrite-api-referencewrite-docs
.githubinternal/design/sitesite/src/write-guideswrite-references
AGENTS.mdastro.config.mjsREADME.md
Collaborator
There was a problem hiding this comment.
Man, I wanna take a pass at all these references. Feels like a lot.
cjpillsbury
added a commit
that referenced
this pull request
Jul 27, 2026
The .claude/plans/spf docs are being removed in the skills-docs-cleanup effort (#1835); drop this branch's net-new spike plan doc so it doesn't reintroduce a doc that effort is deleting. Its OSS prior-art notes are retained in agent memory. Also removes the now-dangling reference to it from the (kept) presentation-timeline-model.md See-also list. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…eanup # Conflicts: # .github/workflows/changelog-prose.yml # internal/design/spf/features/non-zero-pts-support.md # internal/design/spf/presentation-timeline-model.md # site/CLAUDE.md
decepulis
approved these changes
Jul 27, 2026
decepulis
left a comment
decepulis
left a comment
Collaborator
There was a problem hiding this comment.
I reviewed everything that's changed since the last PR (aside from SPF stuff) and it looks good to me!
I'm going to approve this, though I haven't explicitly reviewed things outside of my domain; I'm trusting that the changes your agents made to files that I'm concerned about are similar to changes made elsewhere, and that codeowners who care about those agentic flows have been informed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1833
Summary
Make
.agents/the cross-agent home for repository skills and temporary plans, keepAGENTS.mdas the concise source of durable agent guidance, and reduce duplicated or stale prose in skills, design records, decisions, RFCs, and package documentation.This is an agent-guidance and documentation cleanup only; it does not intentionally change application runtime behavior. Across the full branch it removes 39,779 lines and adds 2,677, for a net reduction of 37,102 lines.
Changes
Agent guidance and skills
AGENTS.mdfiles; reduce matchingCLAUDE.mdfiles to compatibility imports instead of duplicated instructions.claude/skills/copies to direct children of.agents/skills/.claude/skills,.claude/plans, and.opencodealiases from the canonical.agents/tree; generated aliases are not trackedInternal records and package documentation
player,spf,store, anduiareas and preserve newly extracted signal-ownership and reactive-state rationaleRepository rules and enforcement
.agents/plans/is temporary workspace; durable rationale belongs ininternal/design/,internal/decisions/, orrfc/.agents/skills/, use portable metadata, start with a clear action, include a compact input/output example, and avoid explicit sibling-skill loadingTesting
pnpm link:aliasespnpm check:workspace— 10 passed, 0 failedgit diff --check origin/main...HEADpnpm -F @videojs/spf test— unable to start because workspace exports such as@videojs/utils/eventsare unresolved in this worktree; Vitest also reports mixed 4.1.0 and 4.1.2 packagesNote
Low Risk
Documentation and agent-guidance only; no application runtime changes in this diff. Risk is limited to agents following outdated skill names or paths until aliases and
AGENTS.mdrouting are in sync.Overview
Establishes
.agents/as the canonical home for repository agent skills and temporary plans: adds a plans README that forbids treating plans as behavior evidence, and shifts durable guidance toAGENTS.mdplus generated.claude//.opencode/aliases (per existing repo wiring).Replaces the old
.claude/skillslayout with verb-first skills under.agents/skills/—including new workflows for commits/PRs, issues, skill authoring, agent-doc maintenance, branch/docs/API/a11y/Tailwind reviews, UI/API/docs/RFC/design writing, CSS→Tailwind migration, and issue investigation—while collapsing SPF behavior work intochange-spf-behavior(update/refactor/split/merge references) and alignedcreate-*/document-*/implement-*SPF feature and use-case skills with updated slash-command names throughout reference docs.Trims skill reference noise by removing broken or redundant “See Also” links to other skills (e.g. aria/component/api) in UI, API, a11y, and Tailwind reference files; design-doc templates now point temporary mechanics at
.agents/plans/instead of.claude/plans/.Deletes tracked historical implementation plans under
.claude/plans/(including the menus implementation log), leaving only the policy README in the generated alias tree.Reviewed by Cursor Bugbot for commit 3f96324. Bugbot is set up for automated code reviews on this repo. Configure here.