docs: fix selectTextTracks → selectTextTrack in text-tracks reference - #1876
Merged
Conversation
The text-tracks feature reference imported and used a non-existent plural symbol `selectTextTracks`. The real public selector is singular `selectTextTrack` (packages/core/src/dom/store/selectors.ts). Renamed all 6 references.
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (10)
Players (5)
Skins (30)
UI Components (39)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (9)
Skins (27)
UI Components (33)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (68)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (11)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretJS sizes are initial static graph totals (minified + brotli). Lazy dynamic chunks are shown separately when present.
Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Dave Kiss · Slack thread
selectTextTracks, a symbol that does not exist — copying the example would fail to resolve the import.selectTextTrack(singular).site/src/content/docs/reference/feature-text-tracks.mdx. The public selector is defined atpackages/core/src/dom/store/selectors.ts:47; no plural form exists in source.Generated by Claude Code
Note
Low Risk
Documentation-only typo fix with no runtime or API changes.
Overview
Fixes the text-tracks feature reference so copy-paste examples work: all six mentions of the non-existent
selectTextTracksimport/selector are renamed toselectTextTrack, matching the export in core.Updates prose for React
usePlayerand HTMLPlayerController, plus theCaptionsButtonsamples for both frameworks.Reviewed by Cursor Bugbot for commit 82acfd6. Bugbot is set up for automated code reviews on this repo. Configure here.