refactor(media)!: extract media package from core - #1879
Merged
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (10)
Players (5)
Skins (30)
UI Components (39)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (9)
Skins (27)
UI Components (33)
Sizes are marginal over the root entry point. 🧩 @videojs/core
Entries (72)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (12)
📦 @videojs/media
Entries (14)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretJS sizes are initial static graph totals (minified + brotli). Lazy dynamic chunks are shown separately when present.
Run |
mihar-22
force-pushed
the
t3code/move-media-to-package
branch
from
July 28, 2026 00:30
7f24fa1 to
15c93d9
Compare
mihar-22
force-pushed
the
t3code/move-media-to-package
branch
from
July 28, 2026 00:32
15c93d9 to
083a046
Compare
Move media contracts, DOM hosts, and playback engines into @videojs/media. Update workspace consumers and release metadata.
mihar-22
force-pushed
the
t3code/move-media-to-package
branch
from
July 28, 2026 19:55
083a046 to
e3966e1
Compare
mihar-22
marked this pull request as ready for review
July 28, 2026 23:13
luwes
approved these changes
Jul 28, 2026
luwes
left a comment
luwes
left a comment
Collaborator
There was a problem hiding this comment.
Amazing job, I went through it quickly but all looks good including some of the renaming and barrel file changes 👍 I'd also like to see this merged sooner than later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@videojs/mediafor media contracts, state, DOM hosts, and playback engines@videojs/coreRelated to #1861
Verification
@videojs/mediais unclaimed on npm (npm viewreturnsE404)@videojs/media,@videojs/core,@videojs/html,@videojs/react, and the sandbox@videojs/media@10.0.0-beta.25publish artifact withnpm pack --dry-runTest environment note
The combined test command under the repository's Volta Node 22 configuration encounters 31
Intl.DurationFormatavailability failures. The affected core, HTML, and React suites pass under Node 26.Note
High Risk
This is a breaking public API and monorepo-wide import migration touching playback engines, store features, and HTML/React surfaces; regressions would affect streaming, casting, and player state wiring.
Overview
Breaking refactor: media is no longer part of
@videojs/core. A new@videojs/mediapackage owns capability contracts and state types (@videojs/media) plus browser hosts and engines under@videojs/media/dom/*(HLS, DASH, Mux, Vimeo, Simple HLS, Google Cast, etc.). Streaming-related dependencies (hls.js,dashjs,mux-embed,@vimeo/player,@videojs/spf) move with that code; core now depends on@videojs/mediaand drops./dom/media/*and./media/predicateexports.Core UI and DOM store features import media types from
@videojs/media; player/media typing is consolidated inpackages/core/src/dom/player.ts(replacing./media/typesre-exports). HTML and React pull media and predicates from@videojs/media, and custom media elements are split so implementation lives inmedia.tswithindex.tsre-exporting.Host helpers are renamed for clarity:
addComponent→addMediaComponent,getProp/setProp/getOwner→getMediaProp/setMediaProp/getMediaOwner. Release-please, CI test matrix, issue templates, AGENTS.md, internal design docs, and SPF workflow references are updated to point atpackages/mediapaths.Reviewed by Cursor Bugbot for commit 7db0436. Bugbot is set up for automated code reviews on this repo. Configure here.