fix(packages): prevent controls click triggering interactions - #1885
Merged
Conversation
✅ Deploy Preview for vjs10-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Size Report🎨 @videojs/html — no changesPresets (7)
Media (10)
Players (5)
Skins (30)
UI Components (39)
Sizes are marginal over the root entry point. ⚛️ @videojs/react — no changesPresets (7)
Media (9)
Skins (27)
UI Components (33)
Sizes are marginal over the root entry point. 🧩 @videojs/core — no changesEntries (72)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (12)
📦 @videojs/media — no changesEntries (14)
📦 @videojs/spf — no changesEntries (4)
ℹ️ How to interpretJS sizes are initial static graph totals (minified + brotli). Lazy dynamic chunks are shown separately when present.
Run |
sampotts
enabled auto-merge (squash)
July 30, 2026 01:12
cjpillsbury
approved these changes
Jul 30, 2026
cjpillsbury
left a comment
cjpillsbury
left a comment
Collaborator
There was a problem hiding this comment.
Approved with a couple of suggestions (one non-blocking/as a followup)
| override connectedCallback(): void { | ||
| super.connectedCallback(); | ||
|
|
||
| this.setAttribute('data-interactive', ''); |
Collaborator
There was a problem hiding this comment.
thought(non-blocking): this should not block merging/releasing imo, but, as a followup, we may want to consider another attribute or a different name, since this name is kind of "lying." These components aren't interactive. If anything, we're trying to identify them to disable a gesture-based interaction.
Collaborator
Author
There was a problem hiding this comment.
I guess it's more "contains interactive" since it tells the gesture logic to ignore interactions from this element but yeah, we can rename it.
| stateAttrMap: ControlsDataAttrs, | ||
| ref: [forwardedRef], | ||
| props: [{ children }, elementProps], | ||
| props: [{ children }, elementProps, { 'data-interactive': '' }], |
Collaborator
There was a problem hiding this comment.
suggestion(non-blocking): We may want to switch the order of elementProps and { 'data-interactive': '' } here so that folks could override the default (I think?)?
Collaborator
Author
There was a problem hiding this comment.
Would we want them to allow the interactions with the controls container to trigger gestures? I mean I guess we could 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
data-interactiveescape hatch the controls container, preventing clicks from triggering any click interactions bound to the main container.Note
Low Risk
Small, targeted DOM attribute change with tests; affects gesture hit-testing only, not playback or auth.
Overview
Clicks on the controls bar (not just individual buttons or sliders) were still bubbling into the player’s container tap gesture and could toggle play/pause. This PR marks the whole controls root as an interactive surface so those pointer events are ignored by container gestures.
HTML
ControlsElementsetsdata-interactiveinconnectedCallback. ReactControlsRootpasses the same attribute on its rootdiv. Unit tests cover both implementations, core gesture behavior for descendants inside adata-interactiveancestor, and e2e tests for HTML and React verify pointer events on the controls container do not change playback state.Reviewed by Cursor Bugbot for commit d3be0a2. Bugbot is set up for automated code reviews on this repo. Configure here.