Throw when unable to initialize mysofa#89
Open
ePirat wants to merge 1 commit intovideolan:masterfrom
Open
Conversation
Do not silently create a unusable SOFA_HRTF object, instead throw an exception when mysofa did not initialize properly, like when provided with no or a unusable/bogus HRTF file. That way the caller can properly handle this error condition instead of crashing later due to the nullptr. While this technically breaks the API contract, as this did not throw before, this is clearly a better outcome than not handling the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not silently create a unusable SOFA_HRTF object, instead throw an exception when mysofa did not initialize properly, like when provided with no or a unusable/bogus HRTF file.
That way the caller can properly handle this error condition instead of crashing later due to the nullptr.
While this technically breaks the API contract, as this did not throw before, this is clearly a better outcome than not handling the error.
Fix #88