Skip to content

Fix compilation with older GCC versions #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbkempf merged 3 commits into from
May 13, 2026
+16 −4
Merged

Fix compilation with older GCC versions #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ec50f7
SpatialaudioAPI: Add SPAUDIO_DEPRECATED macro
ePirat May 13, 2026
0b7834d
Use SPAUDIO_DEPRECATED instead of the C++ attribute
ePirat May 13, 2026
d2d604e
Reword deprecation messages
ePirat May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions include/AmbisonicProcessor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,9 @@ namespace spaudio {
* Please use AmbisonicRotator instead.
*/

class SPAUDIO_API
[[deprecated("This class is deprecated. Please use AmbisonicRotator class instead.")]]
class
SPAUDIO_DEPRECATED("Please use AmbisonicRotator class instead.")
SPAUDIO_API
AmbisonicProcessor : public AmbisonicBase
{
public:
Expand Down
5 changes: 3 additions & 2 deletions include/AmbisonicShelfFilters.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ namespace spaudio {
/** This class applies frequency dependent basic & max-rE optimisation to a B-format signal using linear phase FIR filters.
* This class is deprecated in favour of AmbisonicOptimFilters, which uses LinkwitzRiley IIR filters to apply frequency dependent gains.
*/
class SPAUDIO_API
[[deprecated("This class is deprecated. Please use AmbisonicOptimFilters class instead.")]]
class
SPAUDIO_DEPRECATED("Please use AmbisonicOptimFilters class instead.")
SPAUDIO_API
AmbisonicShelfFilters : public AmbisonicBase
{
public:
Expand Down
10 changes: 10 additions & 0 deletions include/SpatialaudioAPI.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,14 @@
# define SPAUDIO_API SPATIALAUDIO_IMPORT
#endif

// Deprecation annotation
// For GCC 12 and older we must not mix the attribute syntax
// styles, so in that case, we use __attribute__(()) here, else
// we just use the normal C++ attribute syntax
#if defined(__GNUC__) && (__GNUC__ < 13)
# define SPAUDIO_DEPRECATED(msg) __attribute__((deprecated(msg)))
#else
# define SPAUDIO_DEPRECATED(msg) [[deprecated(msg)]]
#endif

#endif /* SPATIALAUDIO_API_H */
Loading