feat: support optionally setting attributes on components using toggle#218
Closed
dvaergiller wants to merge 1 commit into
Closed
feat: support optionally setting attributes on components using toggle#218dvaergiller wants to merge 1 commit into
dvaergiller wants to merge 1 commit into
Conversation
Allow `name=[expr]` toggle syntax for component attributes in both `maud!` and `rsx!`, mirroring the existing element-attribute toggle (e.g. `a href=[None]`). When the bracketed expression is `None` the member is left at its default; `Some(v)` sets it to `v`. This lets a component user set optionsl attributes without checking each attribute and optionally setting them.
Contributor
Author
|
I think there might be a better solution to align component attributes to regular element attributes. Closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
name=[expr]toggle syntax for component attributes in bothmaud!andrsx!, mirroring the existing element-attribute toggle (e.g.a href=[None]). When the bracketed expression isNonethe member is left at its default;Some(v)sets it tov.This lets a component user set optional attributes without checking each attribute and optionally setting them, and it makes the syntax for components a bit more aligned with regular hypertext tags (since regular tags already have this).