isReachable/isPaired as properties, correct icon#40
Open
nicklan wants to merge 1 commit intovikoadi:masterfrom
Open
isReachable/isPaired as properties, correct icon#40nicklan wants to merge 1 commit intovikoadi:masterfrom
nicklan wants to merge 1 commit intovikoadi:masterfrom
Conversation
This change switches is_reachable and is_paired to fetch the properties instead of trying to call a method. (not sure if/when this changed in the dbus interface, but that's how they are presented for me) This fixes issue vikoadi#31 and (I think) vikoadi#38 This also switches the icon code to use the statusIconName as that seems to have the correct value. Also, in DeviceIndicator, no longer append "-symbolic" as (at least on my system) the icons don't seem to have that in their names.
|
Thanks! this fixed it for me |
mariogrip
approved these changes
Sep 20, 2016
|
+1 fixed my issues |
|
As I understand it, indicator-kdeconnect is now being maintained on the fork https://github.com/Bajoja/indicator-kdeconnect Please consider installing that version instead and check whether your pull request still apply and if does submit it there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change switches is_reachable and is_paired to fetch the properties
instead of trying to call a method. (not sure if/when this changed in
the dbus interface, but that's how they are presented for me)
This fixes issue #31 and (I think) #38
This also switches the icon code to use the statusIconName as that seems
to have the correct value. Also, in DeviceIndicator, no longer append
"-symbolic" as (at least on my system) the icons don't seem to have
that in their names.
(If you'd like these separated, let me know)