Special 'no estimates' message for meninigitis vaccines#74
Special 'no estimates' message for meninigitis vaccines#74david-mears-2 wants to merge 7 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 98.65% 98.66%
=======================================
Files 26 26
Lines 595 598 +3
Branches 146 148 +2
=======================================
+ Hits 587 590 +3
Misses 7 7
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…imc/vaxviz into mrc-6891-helpful-no-estimates-messages
EmmaLRussell
left a comment
EmmaLRussell
left a comment
There was a problem hiding this comment.
Did you also want to include a meningitis special message in the case where some focuses do show results, but one or more meningitis selection does not (in the blue alert beside the legend)?
Also - I've just spotted that if you have 2 focus selections, one of which has no data, you don't see a legend. The user can work out from context of the alert message which one isn't missing, but it might be clearer to show the with-data selection on the legend.
| </p> | ||
| <FwbAlert v-else-if="noDataToDisplay" icon class="w-fit m-auto mt-10"> | ||
| <span v-if="appStore.focuses.length && appStore.focuses.every(f => meningitisVaccines.includes(f)) && !appStore.splitByActivityType"> | ||
| Estimates for {{ appStore.focuses.join(", ") }} are only available at the campaign/routine level.<br/> |
There was a problem hiding this comment.
| Estimates for {{ appStore.focuses.join(", ") }} are only available at the campaign/routine level.<br/> | |
| Estimates for {{ appStore.focuses.join(", ") }} are only available at the activity type level.<br/> |
Don't have strong feeling, but this change would be a little more consistent. But as it is, it gives more context.
| <FwbAlert v-else-if="noDataToDisplay" icon class="w-fit m-auto mt-10"> | ||
| <span v-if="appStore.focuses.length && appStore.focuses.every(f => meningitisVaccines.includes(f)) && !appStore.splitByActivityType"> | ||
| Estimates for {{ appStore.focuses.join(", ") }} are only available at the campaign/routine level.<br/> | ||
| Try selecting ‘Split by activity type’, or view meningitis estimates (a composite of MenA and MenACWYX). |
There was a problem hiding this comment.
Shouldn't we upper case here, as it is in the legend and select control?
| Try selecting ‘Split by activity type’, or view meningitis estimates (a composite of MenA and MenACWYX). | |
| Try selecting ‘Split by activity type’, or view Meningitis estimates (a composite of MenA and MenACWYX). |
There was a problem hiding this comment.
My thinking is that it should be upper case in the legend and select control because it's the first word in a 'sentence' or 'title'; but here, it's not the first word in a sentence or title.
I do think my brain has got polluted to always spelling diseases with capital letters, from seeing them in sentence case so often, but that's not actually normal, see e.g. https://www.nhs.uk/conditions/meningitis/
2 participants
As discussed with Katy, it would be good to make the 'no estimates' message more helpful in the case of MenA and MenACWYX, which are both meningitis vaccines.
I welcome feedback on the phrasing: "Estimates for {{ MenA / MenACWYX }} are only available at the campaign/routine level. Try selecting ‘Split by activity type’, or view meningitis estimates (a composite of MenA and MenACWYX)."