use arel_table in Promotion.with_coupon_code and Promotion.coupons#133
Open
use arel_table in Promotion.with_coupon_code and Promotion.coupons#133
Conversation
|
@ankit1910 Please resolve the conflict and ensure that specs are written for the method/scope you modified. |
ankit1910
force-pushed
the
use_arel_table
branch
from
16ab95c to
4a08518
Compare
ankit1910
force-pushed
the
use_arel_table
branch
from
4a08518 to
a819a74
Compare
|
@ankit1910 Please add description to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use arel_table for scope
.couponsand class_methodwith_coupon_codein promotion model.