Skip to content

Comments

complete rspecs for price model#147

Open
sawangupta92 wants to merge 3 commits intovinsol:masterfrom
sawangupta92:rspec-for-price
Open

complete rspecs for price model#147
sawangupta92 wants to merge 3 commits intovinsol:masterfrom
sawangupta92:rspec-for-price

Conversation

@sawangupta92
Copy link

  1. Use constant AMOUNT_LIMIT for maximum and minimum amount.
  2. Write a shared example for paranoia named “a Paranoid model”
  3. Write rspecs for Included/extended modules, Constants, Associations, Validations, Callbacks, Ransackable attributes, #money, #variant, #ensure_currency
  4. Move #price_including_vat_for and #display_price_including_vat_for to describe block of Instance Methods
  5. Require files of shared folder in spec_helper.rb
  6. Updated rspecs for #price.

@jitendra
Copy link

jitendra commented Mar 3, 2016

@sawangupta92 Please provide details about each small change in the description of this PR.

@jitendra
Copy link

jitendra commented Mar 9, 2016

👍 please resolve conflict

@jitendra jitendra assigned sawangupta92 and unassigned jitendra Mar 9, 2016
1) Add paranoia examples to shared directory
2) Make small code level changes while writing specs
@jitendra
Copy link

@sawangupta92 please raise on Spree with PR description

@jitendra jitendra assigned sawangupta92 and unassigned jitendra Mar 17, 2016
@sawangupta92 sawangupta92 force-pushed the rspec-for-price branch 3 times, most recently from aac5d8c to 5a937c1 Compare March 21, 2016 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants