Open
Conversation
sawangupta92
commented
Mar 1, 2016
- Use constant AMOUNT_LIMIT for maximum and minimum amount.
- Write a shared example for paranoia named “a Paranoid model”
- Write rspecs for Included/extended modules, Constants, Associations, Validations, Callbacks, Ransackable attributes, #money, #variant, #ensure_currency
- Move #price_including_vat_for and #display_price_including_vat_for to describe block of Instance Methods
- Require files of shared folder in spec_helper.rb
- Updated rspecs for #price.
|
@sawangupta92 Please provide details about each small change in the description of this PR. |
|
👍 please resolve conflict |
1) Add paranoia examples to shared directory 2) Make small code level changes while writing specs
0a7b545 to
c97cd6b
Compare
|
@sawangupta92 please raise on Spree with PR description |
aac5d8c to
5a937c1
Compare
5a937c1 to
f19dc3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.