Conversation
mschwerhoff
reviewed
Dec 17, 2021
Contributor
mschwerhoff
left a comment
mschwerhoff
left a comment
There was a problem hiding this comment.
Simply adding all functions seems OK, but I find it incoherent that we are more fine-grained when it comes to methods and predicates.
I believe Marco wrote a more fine-grained dependency analysis once. Did you already ask him?
mschwerhoff
approved these changes
Dec 19, 2021
Contributor
mschwerhoff
left a comment
mschwerhoff
left a comment
There was a problem hiding this comment.
Coarse-grained, but otherwise OK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to domain axioms, methods depend on functions even when there is no explicit call to them.
Fixes #548