refactor: unify keyboard handling on @opentui/keymap useBindings#44
Merged
Conversation
Migrate from useKeyboard to declarative useBindings across the app so navigation, the app-level double-escape, and organise's left/right paging share one keymap layer stack. Priorities (nav 100 > organise 50 > app 10) plus preventDefault: false on escape let input-mode exit bubble to the double-esc handler without both firing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useKeyboard→ declarativeuseBindingsfrom@opentui/keymap/solidinuseKeyboardNav,src/index.tsx(app-level double-escape), andorganise.tsx(tool-window left/right paging).useKeyboardNav(100) > organise left/right (50) > app double-esc (10). Input-modeescapeusespreventDefault: falseso it exits input mode and bubbles to the double-esc handler.enterbinding (terminal keymaps emitreturn) and remove now-unuseduseKeyboard/KeyEventimports.@opentui/keymap@0.2.0dependency.Test plan
bun test— 111 pass, 0 failbun tsc --noEmit— clean