feat(pdf-preview): navigate pages with arrow keys and hjkl#47
Merged
Conversation
…ovider Splits useKeyboardNav into createKeyboardNav (constructor) and useKeyboardNav (context consumer) so descendant panels can share one focus ring instead of each panel spinning up its own. main-ui wraps its tool + preview subtree in the new provider. Adds a persistent field to FocusableElement so consumers can keep long-lived focusable elements registered across effect reruns (clearElements now only drops non-persistent entries). Callers outside the provider fall through to a fresh instance, preserving current behavior for standalone components.
Registers the prev/next page buttons as persistent focusable elements and adds left/right (and h/l) key bindings so users can flip through a previewed PDF without the mouse. Suppressed while a text input has focus or when no file is selected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #45 (KeyboardNavProvider +
persistentfield on FocusableElement).Test plan
bun run typecheckbun test(107/107 pass)