feat(ui): reusable Dropdown component and generic TextInput#48
Merged
Conversation
Introduces a Dropdown primitive that owns option list rendering, open/close, hover/focus highlighting, and keyboard navigation (up/down/j/k, return to select, escape/tab to close). The scrollable option list uses contentOptions for flexDirection so the internal viewport lays out correctly and the scrollbar sits alongside the items. Generalizes TextInput's value/onInput over T so callers can pass strings or numeric values without casting, adds spacing knobs the new page-numbers UI needs, and drops the extra label padding that made stacked inputs look uneven.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dropdown<T>primitive that owns option list rendering, open/close state, hover/focus highlighting, and keyboard nav (up/down/j/k, return to select, esc/tab to close).flexDirectionviacontentOptionsso the internal scrollbox viewport lays out correctly and the vertical scrollbar sits alongside the items (previously misplaced when set on the scrollbox root).TextInputtoTextInput<T>so callers can bind numeric values without stringifying, adds spacing prop knobs, and tidies label padding.Dropdown/DropdownOptionfromcomponents/ui/index.ts.Foundation for the upcoming Page Numbers feature.
Test plan
bun run typecheckbun test(107/107 pass)