feat(panels) AIAssistPanel#609
Conversation
CoverageStmts: 26.25% ▼-0.05% | Branch: 19.62% ▼-0.05% | Funcs: 23.67% ▼-0.11% | Lines: 26.24% ▼-0.05%
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c6626b217
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import type {WidgetPanel, WidgetPanelTheme} from './widget-containers'; | ||
| import type {JSX} from 'preact'; | ||
|
|
||
| import '@openassistant/ui/dist/index.css'; |
There was a problem hiding this comment.
Avoid top-level CSS import in AIAssistPanel module
Importing @openassistant/ui/dist/index.css at module scope makes the new AI panel file side-effectful, and modules/panels/src/index.ts now re-exports that file so any root import of @deck.gl-community/panels will eagerly evaluate it. This breaks non-bundled Node/SSR consumers (including the CJS entrypoint) that do not have a CSS loader, even if they never use AIAssistPanel, because module initialization fails on the .css import.
Useful? React with 👍 / 👎.
Summary
Adds
AIAssistPanelto@deck.gl-community/panels, based on the deck.gl AI assistant widget PR. The new panel is deck-independent and can be used through existing panel containers or deck-facing panel widgets.Changes
AIAssistPanel,AIAssistPanelProps, andAIAssistPanelConfigonConfigChangeyarn.lockValidation
yarnyarn test --project browser modules/panels/src/widget-panels/ai-assist-panel.test.tsxnpx tsc -p modules/panels/tsconfig.json --noEmityarn lintNote:
yarn lintpasses but still reports existing warnings in unrelated modules.