Skip to content

fix: place basemap inside deckgl to avoid contexts conflict#618

Merged
charlieforward9 merged 1 commit into
visgl:masterfrom
MCesarczyk:fix/react-editor-example
Apr 30, 2026
Merged

fix: place basemap inside deckgl to avoid contexts conflict#618
charlieforward9 merged 1 commit into
visgl:masterfrom
MCesarczyk:fix/react-editor-example

Conversation

@MCesarczyk
Copy link
Copy Markdown
Contributor

Fixes: #617

Replaced DeckGL component with DeckGLOverlay to properly interact basemap with Deck instance.

@MCesarczyk MCesarczyk force-pushed the fix/react-editor-example branch from 56a0955 to d332cd3 Compare April 30, 2026 14:54
@MCesarczyk MCesarczyk changed the title fix: use deckgl overlay instead of full deckgl inside maplibre component fix: place basemap inside deckgl to avoid contexts conflict Apr 30, 2026
@MCesarczyk
Copy link
Copy Markdown
Contributor Author

Don't know if it's only my local setup issue but in order to run dev env locally without errors I needed to make such changes:

  • in tsconfig.json in "compilerOptions":
    • from "jsx": "react"
    • to "jsx": "react-jsx",
  • in examples/editable-layers/editor/example.tsx:
    • from import '@deck.gl/widgets/stylesheet.css'
    • to import '@deck.gl/widgets/dist/stylesheet.css';
  • in examples/editable-layers/widget/app.tsx:
    • from import '@deck.gl/widgets/stylesheet.css'
    • to import '@deck.gl/widgets/dist/stylesheet.css';

Using:

  • mise v2026.4.28
  • node v24.14.0
  • yarn v4.14.1

@charlieforward9
Copy link
Copy Markdown
Collaborator

The stylesheet has always been a bit problematic, happy to accept a PR that inspects this further.

@charlieforward9 charlieforward9 merged commit 3587233 into visgl:master Apr 30, 2026
3 of 4 checks passed
@MCesarczyk MCesarczyk deleted the fix/react-editor-example branch May 1, 2026 21:21
@MCesarczyk
Copy link
Copy Markdown
Contributor Author

The stylesheet has always been a bit problematic, happy to accept a PR that inspects this further.

I've collected all initial errors occuring while running examples in local dev in this issue: #624 and created PR: #625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] React editor in examples section not usable

2 participants