fix(editable-layers) Update nearestPointOnLine so it saves distance correctly#629
Open
jake-goldsmith wants to merge 2 commits into
Open
fix(editable-layers) Update nearestPointOnLine so it saves distance correctly#629jake-goldsmith wants to merge 2 commits into
jake-goldsmith wants to merge 2 commits into
Conversation
Also removes dead code for handling multi part geometries since they are handled at higher levels
jake-goldsmith
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies the nearestPointOnLine function - also removes dead code for handling multi part geometries since they are handled at higher levels.
The key bugfix here is setting
dist: minDiston the returned object. Previously it was returning a different distance metric so when handling features with multiple lines the results were being compared incorrectly. (See issue #622).Modify Mode intermediate points are now working as expected:
Screen.Recording.2026-05-07.144827.mp4