[geo-layers] Fix globe tile culling near poles#10297
Closed
charlieforward9 wants to merge 1 commit into
Closed
Conversation
|
Coverage is 83.764% — NEW-HEAT:codex/globe-tile-cull-rect into visgl:cr/feat/terrain-layer-globe-grid. No base build found for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes TileLayer/Tileset2D visibility in GlobeView near the poles by bypassing screen
cullRectlng/lat bounds culling for globe viewports.getOSMTileIndicesalready uses the globe frustum traversal to select visible tiles. The latercullRectpath approximates the screen rectangle as a simple lng/lat bbox from corner unprojection, which breaks around polar caps and can hide every selected tile.Validation
npx vitest run --project headless test/modules/geo-layers/tileset-2d/tileset-2d.spec.tsStacked on #10250 /
cr/feat/terrain-layer-globe-grid.