feat(geo-layers): Make TileIndex generic#10299
Open
kylebarron wants to merge 10 commits into
Open
Conversation
|
coverage: 83.796%. remained the same — kylebarron:kyle/tileset2d-generic-tileindex into visgl:master |
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Continuation of #6816 and closure of todo comments. Happy to make an issue if you need.
Background
Change List
Tileset2D,Tile2DHeader,TileLoadDataProps,RefinementStrategyto be able to customize the shape of theTileIndexFuture Work
TileLayer, so that theTileLayerand theTilesetClassare wired together, and the user'sgetTileDataandrenderSubLayerscan be aware of the underlying tile index type.