-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(examples): add useDevicePixels toggle to basemap-browser #10332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chrisgervang
wants to merge
24
commits into
master
Choose a base branch
from
chrisgervang/basemap-browser-use-device-pixels
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9f0c4b8
chore(core) Adopt luma CanvasContext
ibgreen 0000d5a
fix
ibgreen 97d1cfe
Merge branch 'master' into ib/canvas-context-93
chrisgervang 8076215
chore(core): route canvas sizing through CanvasContext
ibgreen 1a84865
fix(google-maps): update overlay style container
ibgreen 99803a5
fix(core): sync attached gl drawing buffer on resize
ibgreen 8d8f329
prettier
ibgreen e69f9f4
docs: add agent merge guidance
ibgreen d4a0574
fix(react): preserve element props typing
ibgreen 8d95fcf
Merge branch 'master' into ib/canvas-context-93
ibgreen f39d9c2
docs: expand merge readiness guidance
ibgreen cc3a261
fix
ibgreen b13922f
test(core): isolate canvas context resize devices
ibgreen 9e26875
Revert "test(core): isolate canvas context resize devices"
ibgreen f83ab0d
test(core): avoid shared canvas context mutation
ibgreen cdeac8f
test(core): avoid shared picker canvas context mutation
ibgreen 2e46973
fix(core): only forward explicit device pixel ratio
ibgreen 90358e6
fix(core): avoid replaying default props into canvas context
ibgreen aa1cbb7
fix(core): repopulate invalid picking color cache
ibgreen 2c0070d
Address comments
ibgreen fbdf106
feat(examples): add useDevicePixels toggle to basemap-browser
chrisgervang fd19f6d
feat(examples): use basemap pixelRatio for interleaved mode + add CDN…
chrisgervang 82902eb
Merge remote-tracking branch 'origin/master' into chrisgervang/basema…
chrisgervang cbecd54
fix(examples): persist useDevicePixels in URL params
chrisgervang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.