Task/update cloudinary to version 2 #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a race condition in the TYPO3 BE that occurred on backend forms with in line elements. Load the external cloudinary js library via requireJS to ensure its availability when the custom JS in the TYPO3 backend tries to access the global object.
…aced (#34) Extend the webhook controller to flush the local caches if an image gets replaced (update override) in Cloudinary.
The cloudinary extension tries to replace missing images with a default emergency fallback image. This may lead to invalid crop instructions for Cloudinary, as the emergency image may be smaller than the original image. Recover from these Cloudinary exceptions by returning an empty image instead of dying with a type excpetion.
Co-authored-by: Hannes Lau <SomeBdyElse@users.noreply.github.com>
* [BUGFIX] Use identifier_hash in CloudinaryScanService The `fileExistsInStorage()` method currently performs a SQL query to count records, but suffers from slow performance due to the absence of an index on the `identifier` field. This results in a full table scan. To address this issue, this commit refactors the method to utilize the pre-existing `identifier_hash` field, specifically designed for efficient data searches. --------- Co-authored-by: Daniel Huf <daniel.huf@visol.ch> Co-authored-by: Hannes Lau <SomeBdyElse@users.noreply.github.com>
Stay below the transformation megapixel limit by prepending a scale down transformation for large images.
SomeBdyElse
force-pushed
the
task/update-cloudinary-to-version-2
branch
from
e474acc to
7fd9ec0
Compare
Fix a missing import that caused a bug when rendering large images via Cloudinary. References: 7fd9ec0
Fix a bug where processed files would not be recognized if the cloudinary cloud uses a cname. Remove the cloud name from the processed file identifier
Remove unused protected method, accidentally introduced with f317925
When a file gets renamed in Cloudinary, do not only update the file identifier in the local sys_file table, but also the sys_file name.
As defined in AbstractHierarchicalFilesystemDriver::canonicalizeAndCheckFileIdentifier
This was referenced Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.