fix(map): Normalize winding order to CCW & replace d3-geo with turf LINDASSUP-247#2542
Draft
fix(map): Normalize winding order to CCW & replace d3-geo with turf LINDASSUP-247#2542
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…INDASSUP-247
- Previously the received winding order of polygons has not been
modified. This caused issues with helpers relying on a specific
winding order. We now "rewind" all polygons to CCW ("right hand
rule"), right after parsing, as is the standard with GeoJSON.
- The d3-geo helpers rely on a CW winding order, which would require a
rewinding before each call. Therefore d3-geo is now replaced with
equivalent helpers from turf, that use the CCW winding order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes LINDASSUP-247
How to test
Heavy Metal Soil Contamination: The map should be zoomed to Switzerland, not the whole world (this was the current bug).Heavy Metal Soil Contamination: The map should (still) be zoomed to Switzerland.